ci : use less jobs when building with sanitizers#19411
Merged
Conversation
CISC
reviewed
Feb 7, 2026
| -DLLAMA_SANITIZE_ADDRESS=${{ matrix.sanitizer == 'ADDRESS' }} \ | ||
| -DLLAMA_SANITIZE_THREAD=${{ matrix.sanitizer == 'THREAD' }} \ | ||
| -DLLAMA_SANITIZE_UNDEFINED=${{ matrix.sanitizer == 'UNDEFINED' }} | ||
| cmake --build build --config ${{ matrix.build_type }} -j ${env:NUMBER_OF_PROCESSORS} --target llama-server |
Member
There was a problem hiding this comment.
I think this was actually the problem, it looks like this is not defined, thus running the build with just -j...
CISC
reviewed
Feb 7, 2026
CISC
reviewed
Feb 7, 2026
CISC
reviewed
Feb 7, 2026
Member
|
It might not be necessary to limit jobs to less than |
Member
Author
|
Yes, let's give it a try without the reduction first. |
CISC
approved these changes
Feb 7, 2026
Member
CISC
left a comment
There was a problem hiding this comment.
Running them once more just to confirm.
Member
|
Things look good, will merge this now to have working CI for next PR (moving server tests). |
liparetejas
pushed a commit
to liparetejas/llama.cpp
that referenced
this pull request
Feb 23, 2026
…9411) * ci : use less jobs when building with sanitizers * cont : fix nproc * cont : fix the fix * cont : simplify
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 2, 2026
…9411) * ci : use less jobs when building with sanitizers * cont : fix nproc * cont : fix the fix * cont : simplify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #19291 (comment)
I think this might help with sanitizer jobs being randomly terminated (such as https://github.com/ggml-org/llama.cpp/actions/runs/21761592313/job/62786390511).