cuda : cuda graphs now compare all node params#19383
Merged
Conversation
am17an
approved these changes
Feb 6, 2026
|
After this change, the GTX 970m 3GB (CUDA 5.2) and T2000 4GB (CUDA 7.5) stopped working completely. b7951 everything works fine. All CUDA13 drivers, and Windows 11, are always the latest. |
Contributor
|
Not sure how this PR can cause an issue, probably the issue is elsewhere. I have high confidence in this because this path is not even exercised for anything below ampere (cc 8.9) |
|
Sorry, something went wrong. |
liparetejas
pushed a commit
to liparetejas/llama.cpp
that referenced
this pull request
Feb 23, 2026
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #19338 (comment)
This should fix the CUDA graph usage logic when the ops have variable op params. This issue is most pronounced during
test-backend-ops.