Skip to content

llama : rename llama-sampling to llama-sampler#19363

Merged
danbev merged 1 commit intoggml-org:masterfrom
danbev:rename-llama-sampling
Feb 6, 2026
Merged

llama : rename llama-sampling to llama-sampler#19363
danbev merged 1 commit intoggml-org:masterfrom
danbev:rename-llama-sampling

Conversation

@danbev
Copy link
Member

@danbev danbev commented Feb 5, 2026

This commit addresses the TODO in llama-sampling.h to rename that header and the implementation to llama-sampler.

This commit addresses the TODO in llama-sampling.h to rename that header
and the implementation to llama-sampler.
@danbev danbev requested a review from ggerganov as a code owner February 5, 2026 13:57
@danbev
Copy link
Member Author

danbev commented Feb 6, 2026

I was able to build examples/llama.android locally using gradle so I don't think that failure is related to this PR so I'll merge this and follow up if the error persists.

@danbev danbev merged commit e696cfc into ggml-org:master Feb 6, 2026
75 of 78 checks passed
@danbev danbev deleted the rename-llama-sampling branch February 6, 2026 06:27
liparetejas pushed a commit to liparetejas/llama.cpp that referenced this pull request Feb 23, 2026
This commit addresses the TODO in llama-sampling.h to rename that header
and the implementation to llama-sampler.
bartowski1182 pushed a commit to bartowski1182/llama.cpp that referenced this pull request Mar 2, 2026
This commit addresses the TODO in llama-sampling.h to rename that header
and the implementation to llama-sampler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants