vulkan: make FA mask/softcap enables spec constants#19309
Merged
0cc4m merged 3 commits intoggml-org:masterfrom Feb 6, 2026
Merged
vulkan: make FA mask/softcap enables spec constants#193090cc4m merged 3 commits intoggml-org:masterfrom
0cc4m merged 3 commits intoggml-org:masterfrom
Conversation
4131daf to
9ffaf56
Compare
Collaborator
Author
|
The lavapipe CI job timed out due to the increased number of shader compiles, and the compiler is pretty slow. I've disabled specializing for sinks, hopefully that will resolve it. |
Collaborator
Author
|
Had to bump the timeout, but #19381 ought to get the runtime back under control. |
liparetejas
pushed a commit
to liparetejas/llama.cpp
that referenced
this pull request
Feb 23, 2026
* vulkan: make FA mask/softcap enables spec constants * don't specialize for sinks * bump timeout a little bit
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 2, 2026
* vulkan: make FA mask/softcap enables spec constants * don't specialize for sinks * bump timeout a little bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stacked on #19281.(merged)This allows the compiler to do a bit better at overlapping loads and math (e.g. loading V can start while computing Q*K^t is still happening). Worth a couple percent for coopmat2, less for coopmat1/scalar.