Skip to content

ci : transform release binary root dir in tar to llama-bXXXX#17773

Merged
CISC merged 2 commits intomasterfrom
cisc/ci-release-tar-root-dir
Dec 5, 2025
Merged

ci : transform release binary root dir in tar to llama-bXXXX#17773
CISC merged 2 commits intomasterfrom
cisc/ci-release-tar-root-dir

Conversation

@CISC
Copy link
Member

@CISC CISC commented Dec 4, 2025

Avoid storing . as root dir in tar.

Copy link
Collaborator

@pwilkin pwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed line 717 :)

@CISC
Copy link
Member Author

CISC commented Dec 5, 2025

Missed line 717 :)

Did not, it's not using ., but we can change that too I suppose...

Edit: or actually, no, I think llama.xcframework is the expected root name.

Copy link
Collaborator

@taronaeo taronaeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS is a little problematic, unfortunately. --transform doesn't seem to be supported, while Linux does.

$ tar -czvf llama-b000-bin-macos-arm64.tar.gz --transform "s,./,llama-b000/," -C ./build/bin .         
tar: Option --transform is not supported
Usage:
  List:    tar -tf <archive-filename>
  Extract: tar -xf <archive-filename>
  Create:  tar -cf <archive-filename> [filenames...]
  Help:    tar --help

@CISC
Copy link
Member Author

CISC commented Dec 5, 2025

macOS is a little problematic, unfortunately. --transform doesn't seem to be supported, while Linux does.

Ah, damn, no worries though, it has -s.

Copy link
Collaborator

@pwilkin pwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aight, don't have a Mac to test on, Linux side seems OK

@CISC CISC requested a review from taronaeo December 5, 2025 00:25
Copy link
Collaborator

@taronaeo taronaeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as intended now :)

@github-actions github-actions bot added the devops improvements to build systems and github actions label Dec 5, 2025
@CISC CISC merged commit 03d9a77 into master Dec 5, 2025
2 checks passed
@CISC CISC deleted the cisc/ci-release-tar-root-dir branch December 5, 2025 00:50
0Marble pushed a commit to 0Marble/llama.cpp that referenced this pull request Dec 18, 2025
…g#17773)

* transform release binary root dir in tar to llama-bXXXX

* bsdtar supports -s instead of --transform
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
…g#17773)

* transform release binary root dir in tar to llama-bXXXX

* bsdtar supports -s instead of --transform
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
* transform release binary root dir in tar to llama-bXXXX

* bsdtar supports -s instead of --transform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: .tar.gz spams the directory it's extracted in, even if the OS is supposed to create a folder for it by default

3 participants