vulkan: remove shell call from vulkan-shaders-gen tool, revert file check#17219
Merged
vulkan: remove shell call from vulkan-shaders-gen tool, revert file check#17219
Conversation
jeffbolznv
reviewed
Nov 12, 2025
Contributor
|
It compiles completely with Edit: whoops, looks like I've tested before the latest changes. |
jeffbolznv
reviewed
Nov 12, 2025
jeffbolznv
approved these changes
Nov 12, 2025
Collaborator
Author
|
@MaggotHATE Sorry about the changes, can you test the latest version? |
Acly
reviewed
Nov 12, 2025
Acly
approved these changes
Nov 12, 2025
Contributor
|
Tested again, works with the same setup. I should, however, point out two things:
Tested again on latest commit, all good, thank you! |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
…heck (ggml-org#17219) * vulkan: remove shell call from vulkan-shaders-gen tool * use string vector for command execution * Fix condition * use string, remove const_cast * Fix dependency file quotation on Windows --------- Co-authored-by: Jeff Bolz <jbolz@nvidia.com>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
…heck (#17219) * vulkan: remove shell call from vulkan-shaders-gen tool * use string vector for command execution * Fix condition * use string, remove const_cast * Fix dependency file quotation on Windows --------- Co-authored-by: Jeff Bolz <jbolz@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the shell invocation from the vulkan-shaders-gen tool, and instead splits the string and feeds separate arguments into
execvp. This way, no shell is needed. I also removed the file check on glslc.@MaggotHATE Please check if this works for you.