CUDA: Remove unneded bias/gate dims in fused mmvq#16858
Merged
am17an merged 3 commits intoggml-org:masterfrom Nov 1, 2025
Merged
CUDA: Remove unneded bias/gate dims in fused mmvq#16858am17an merged 3 commits intoggml-org:masterfrom
am17an merged 3 commits intoggml-org:masterfrom
Conversation
Pointed out [here](ggml-org#16847 (comment)) that only a single value is needed per target col per thread
JohannesGaessler
approved these changes
Oct 30, 2025
Collaborator
JohannesGaessler
left a comment
There was a problem hiding this comment.
Since you're already making another PR, please explicitly unroll the loops over ncols_dst.
Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
c66a33d to
f79bd92
Compare
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* CUDA: Remove unneded bias/gate dims in fused mmvq Pointed out [here](ggml-org#16847 (comment)) that only a single value is needed per target col per thread * Apply suggestions from code review Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * Fix "Error 991-D: extra braces are nonstandard" during compilation --------- Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* CUDA: Remove unneded bias/gate dims in fused mmvq Pointed out [here](ggml-org/llama.cpp#16847 (comment)) that only a single value is needed per target col per thread * Apply suggestions from code review Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * Fix "Error 991-D: extra braces are nonstandard" during compilation --------- Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointed out
here that only a single value is needed per target col per thread