devops: fix binaries release failure for s390x#16664
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
|
I think it would be preferable if you updated this for llama.cpp/ggml/src/CMakeLists.txt Lines 374 to 376 in cec5edb And that requires additional support here: llama.cpp/ggml/src/ggml-cpu/CMakeLists.txt Lines 467 to 468 in cec5edb |
|
What is the exact reason for not being able to make additional builds btw? |
CISC
left a comment
There was a problem hiding this comment.
Please see if GGML_CPU_ALL_VARIANTS is possible, but ok to merge as-is for now.
A couple of things:
|
|
I can dig deeper into Point 2 at a later timing to check if Point 2 is still a problem. If it isn't, then I guess we can build for IBM z16 and z17 as well, but it would definitely require a GCC version bump |
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Done, looks good here too: https://github.com/ggml-org/llama.cpp/actions/runs/18631002307/job/53115650493. Re-requesting review just in case I missed anything. |
|
Ah, you need to implement |
|
Let's merge as-is for now to get release build working again though. |
Or since it seems it only built the z15 target perhaps it works just fine... |
Ehh, you're right. We need to implement I'll work on this sometime next week when I get the time. But I guess whoever that downloads the distributable binaries will have to rename |
Good thing I mentioned it might not work yet in the merge then, we'll see if anyone reads that or not. :) |
…t) (ggml-org#16664) * devops: initial patch Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: forgot the z15 suffix Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: attempt at impl GGML_CPU_ALL_VARIANTS for s390x Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: rm baseline version Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> --------- Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
…t) (ggml-org#16664) * devops: initial patch Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: forgot the z15 suffix Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: attempt at impl GGML_CPU_ALL_VARIANTS for s390x Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: rm baseline version Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> --------- Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
…t) (#16664) * devops: initial patch Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: forgot the z15 suffix Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: attempt at impl GGML_CPU_ALL_VARIANTS for s390x Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> * devops: rm baseline version Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> --------- Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Ref: #16648 (comment) https://github.com/ggml-org/llama.cpp/actions/runs/18629232454/job/53111541762#step:5:42
This should fix the release step being broken. Seem to be working correctly now: https://github.com/ggml-org/llama.cpp/actions/runs/18630134536/job/53113635007