CUDA: topk-moe: add optional parameter for gpt-oss#16649
Merged
am17an merged 3 commits intoggml-org:masterfrom Oct 21, 2025
Merged
CUDA: topk-moe: add optional parameter for gpt-oss#16649am17an merged 3 commits intoggml-org:masterfrom
am17an merged 3 commits intoggml-org:masterfrom
Conversation
jeffbolznv
added a commit
to jeffbolznv/llama.cpp
that referenced
this pull request
Oct 21, 2025
49a541e to
17c3927
Compare
JohannesGaessler
approved these changes
Oct 21, 2025
ye-NX
pushed a commit
to ye-NX/llama.cpp
that referenced
this pull request
Oct 21, 2025
|
how to use this? |
Collaborator
Author
|
@avidwriter if you are using the CUDA backend, with the latest master it should already be included |
pwilkin
pushed a commit
to pwilkin/llama.cpp
that referenced
this pull request
Oct 23, 2025
jeffbolznv
added a commit
to jeffbolznv/llama.cpp
that referenced
this pull request
Oct 26, 2025
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
…#16656) * vulkan: Update topk_moe fusion to handle gpt's late softmax Based on ggml-org#16649. * Add ggml_check_edges * Add sync logging to show fusion effects * handle clamp added in ggml-org#16655 * Update ggml/src/ggml-impl.h Co-authored-by: Diego Devesa <slarengh@gmail.com>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* vulkan: Update topk_moe fusion to handle gpt's late softmax Based on #16649. * Add ggml_check_edges * Add sync logging to show fusion effects * handle clamp added in #16655 * Update ggml/src/ggml-impl.h Co-authored-by: Diego Devesa <slarengh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at this kernel I realized that it is relatively easy to add it for gpt-oss, which does the softmax after the top-k.
Performance on a 4090: