Merged
Conversation
CISC
reviewed
Nov 13, 2025
bartowski1182
commented
Nov 13, 2025
ngxson
reviewed
Nov 13, 2025
CISC
reviewed
Nov 13, 2025
bartowski1182
commented
Nov 13, 2025
CISC
reviewed
Nov 13, 2025
CISC
reviewed
Nov 13, 2025
CISC
reviewed
Nov 13, 2025
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
CISC
approved these changes
Nov 14, 2025
ngxson
approved these changes
Nov 14, 2025
Comment on lines
+14
to
+15
| inpL = ggml_scale(ctx0, inpL, sqrtf(float(n_embd))); | ||
| cb(inpL, "inp_embd_scaled", -1); |
Contributor
There was a problem hiding this comment.
not very important to fix right now, but if the model supports multimodal in the future, you may need to skip scaling if the input is non-text:
llama.cpp/src/models/gemma3-iswa.cpp
Lines 11 to 15 in 45c6ef7
Contributor
Author
There was a problem hiding this comment.
Interesting, good to know thanks !
Member
|
@bartowski1182 @ggerganov Merging in a little while unless you have anything more to add. |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* Add AFMOE model support * Update to vocab * Add model sizing * Undo Rope change for ARCEE model * Address review comments * Update modeling code is_sliding -> use_rope, replace hard-coded logic * Fix AFMOE tokenizer * Update convert_hf_to_gguf.py Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update convert_hf_to_gguf.py Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update AFMoE tokenizer class identification to be more unique --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* Add AFMOE model support * Update to vocab * Add model sizing * Undo Rope change for ARCEE model * Address review comments * Update modeling code is_sliding -> use_rope, replace hard-coded logic * Fix AFMOE tokenizer * Update convert_hf_to_gguf.py Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update convert_hf_to_gguf.py Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * Update AFMoE tokenizer class identification to be more unique --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for upcoming AfmoeForCausalLM
Tokenizer is public ahead of model launch to avoid breaking conversion code
Make sure to read the contributing guidelines before submitting a PR