Skip to content

FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles#161

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
hoangmit:patch-1
Mar 15, 2023
Merged

FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles#161
ggerganov merged 1 commit intoggml-org:masterfrom
hoangmit:patch-1

Conversation

@hoangmit
Copy link
Contributor

@hoangmit hoangmit commented Mar 15, 2023 •
edited
Loading

Without the "static" quantifier, it fails to compile in clang:

ld.lld: error: undefined symbol: packNibbles
>>> referenced by ggml.c:520 (llama_cpp/ggml.c:520)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(quantize_row_q4_0)

ld.lld: error: undefined symbol: bytesFromNibbles
>>> referenced by ggml.c:1434 (llama_cpp/ggml.c:1434)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(ggml_vec_dot_q4_0)
>>> referenced by ggml.c:1435 (llama_cpp/ggml.c:1435)
>>>               .../llama_cpp/__ggml__/__objects__/ggml.c.pic.o:(ggml_vec_dot_q4_0)
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

@hoangmit
inline -> static inline for "bytesFromNibbles"
405d94e 
Without "static" prefix, it fails to compile in clang
@hoangmit hoangmit changed the title inline -> static inline for "bytesFromNibbles" "inline" -> "static inline" for "bytesFromNibbles" Mar 15, 2023
@hoangmit hoangmit changed the title "inline" -> "static inline" for "bytesFromNibbles" "inline" -> "static inline" for bytesFromNibbles and packNibbles Mar 15, 2023
@hoangmit hoangmit changed the title "inline" -> "static inline" for bytesFromNibbles and packNibbles FIX: "inline" -> "static inline" for bytesFromNibbles and packNibbles Mar 15, 2023
@ggerganov ggerganov merged commit 113e685 into ggml-org:master Mar 15, 2023
@setzer22 setzer22 mentioned this pull request Mar 15, 2023
Closed
6 tasks
blackhole89 pushed a commit that referenced this pull request Mar 15, 2023
@hoangmit @blackhole89
inline -> static inline for "bytesFromNibbles" (#161)
aaf0b51 
Without "static" prefix, it fails to compile in clang
Deadsg pushed a commit to Deadsg/llama.cpp that referenced this pull request Dec 19, 2023
@abetlen
Merge pull request ggml-org#161 from abetlen/dependabot/pip/pytest-7.3.1
8a692a5 
Bump pytest from 7.2.2 to 7.3.1
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Closed
SamuelOliveirads pushed a commit to SamuelOliveirads/llama.cpp that referenced this pull request Dec 29, 2025
@ikawrakow
MSVC fixes (ggml-org#161)
1a0a35d 
Closes ggml-org#160 

* MSVC fixes

* One more

---------

Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoangmit @ggerganov