ci : fix hang in windows-hip build/release#15365
Merged
Conversation
slaren
approved these changes
Aug 17, 2025
Collaborator
Author
|
Interesting, we got our first timeout (notice the Fails at build due to missing So, either the installation suddenly took more than twice as long as normal and was aborted, or we encountered the previous hang issue. |
danbev
added a commit
that referenced
this pull request
Sep 10, 2025
This commit adds caching of the ROCm installation for the windows-latest-cmake-hip job. The motivation for this is that the installation can sometimes hang and/or not complete properly leaving an invalid installation which later fails the build. By caching the installation hopefully we can keep a good installation available in the cache and avoid the installation step. Refs: #15365
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* fix hang in windows-latest-cmake-hip * apply fix to release as well
blime4
pushed a commit
to blime4/llama.cpp
that referenced
this pull request
Feb 5, 2026
This commit adds caching of the ROCm installation for the windows-latest-cmake-hip job. The motivation for this is that the installation can sometimes hang and/or not complete properly leaving an invalid installation which later fails the build. By caching the installation hopefully we can keep a good installation available in the cache and avoid the installation step. Refs: ggml-org/llama.cpp#15365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hang is probably because some sub-process is hanging, so the 10 minute timeout might not be necessary (
WaitForExitonly waits for main process, unlike-Wait).