ggml: fixes #12846 compilation error#12848
Merged
ggerganov merged 4 commits intoggml-org:masterfrom Apr 11, 2025
Merged
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
66e9fe0 to
c2b19c8
Compare
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
slaren
approved these changes
Apr 9, 2025
slaren
reviewed
Apr 9, 2025
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
Collaborator
Author
Collaborator
Author
|
Hey @ericcurtin by any chance could you help to merge this? Thank you in advance! |
ggerganov
approved these changes
Apr 11, 2025
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
* ggml: fixes ggml-org#12846 compilation error Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: add documentation for code change Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: refactor to type-cast and update documentation Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: update documentation to provide full issue link Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> --------- Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
Dec 20, 2025
* ggml: fixes ggml-org#12846 compilation error Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: add documentation for code change Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: refactor to type-cast and update documentation Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> * ggml: update documentation to provide full issue link Signed-off-by: Aaron Teo <aaron.teo1@ibm.com> Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com> --------- Co-authored-by: Aleksei Nikiforov <aleksei.nikiforov@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the compilation error introduced in 995083e for s390x platform. Please refer to #12846 for more information.
cc: @AlekseiNikiforovIBM