Skip to content

ggml: add names to tensors#1268

Merged
slaren merged 2 commits intoggml-org:masterfrom
slaren:ggml-names
May 2, 2023
Merged

ggml: add names to tensors#1268
slaren merged 2 commits intoggml-org:masterfrom
slaren:ggml-names

Conversation

@slaren
Copy link
Copy Markdown
Member

@slaren slaren commented May 1, 2023

  • Adds a name field to ggml_tensor
  • Adds accessor functions ggml_get_name and ggml_set_name
    • While we normally don't use accessors, in this case it seemed necessary as the maximum length may change
  • Modifies ggml_graph_dump_dot to use the names in the graph
  • Modifies llama.cpp to add names to most tensors

Example graph (heavily inspired by #915 (comment)):

llama dot

@slaren slaren mentioned this pull request May 1, 2023
Closed
ggerganov
ggerganov approved these changes May 1, 2023
View reviewed changes
ggml.h Outdated
Copy link
Copy Markdown
Member

@ggerganov ggerganov May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it to remind us

@slaren slaren merged commit 2d099e5 into ggml-org:master May 2, 2023
@slaren slaren deleted the ggml-names branch May 2, 2023 14:03
DannyDaemonic pushed a commit to DannyDaemonic/llama.cpp that referenced this pull request May 2, 2023
@slaren @DannyDaemonic
ggml: add names to tensors (ggml-org#1268)
bad9913 
* ggml: add names to tensors

* minor improvements to dot file formatting
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slaren @ggerganov