Fix build for gcc 8 and test in CI#1154
Merged
sw merged 1 commit intoggml-org:masterfrom Apr 24, 2023
Merged
Conversation
ggerganov
approved these changes
Apr 24, 2023
player1537
pushed a commit
to player1537-forks/llama.cpp
that referenced
this pull request
May 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 8 doesn't know
_mm_loadu_si64, use the equivalent_mm_loadl_epi64which generates the same opcode.Set the
makeCI check to run on Ubuntu 20.04 and GCC 8 to prevent such problems in the future. Of course we might decide to drop support for these old versions some time in the future.See a failing check here.
Resolves #1120