Avoid -march=native when reproducible build is wanted#11366
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Jan 24, 2025
Merged
Avoid -march=native when reproducible build is wanted#11366ggerganov merged 1 commit intoggml-org:masterfrom
ggerganov merged 1 commit intoggml-org:masterfrom
Conversation
ggerganov
approved these changes
Jan 24, 2025
Member
ggerganov
left a comment
There was a problem hiding this comment.
I suppose this env variable is specific only for this particular use case and it won't clash with some other workflow?
Maybe add a message(STATUS ...) to be more verbose when GGML_NATIVE_DEFAULT is set to OFF.
See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Without this patch, compiling on different machines produced different binaries, which made verification of results difficult. Fixes: ggml-org#11317 This patch was done while working on reproducible builds for openSUSE.
Contributor
Author
|
The variable is defined in https://reproducible-builds.org/specs/source-date-epoch/ - multiple distributions (Debian, Arch, openSUSE) set it during build to achieve reproducible builds results. I pushed an update with |
anagri
pushed a commit
to BodhiSearch/llama.cpp
that referenced
this pull request
Jan 26, 2025
…rg#11366) See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Without this patch, compiling on different machines produced different binaries, which made verification of results difficult. Fixes: ggml-org#11317 This patch was done while working on reproducible builds for openSUSE.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…rg#11366) See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Without this patch, compiling on different machines produced different binaries, which made verification of results difficult. Fixes: ggml-org#11317 This patch was done while working on reproducible builds for openSUSE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://reproducible-builds.org/ for why this is good.
Without this patch, compiling on different machines produced different binaries, which made verification of results difficult.
Fixes: #11317
This PR was done while working on reproducible builds for openSUSE.