[CANN] RoPE and CANCAT operator optimization#10488
Merged
hipudding merged 1 commit intoggml-org:masterfrom Nov 26, 2024
Merged
Conversation
hipudding
requested changes
Nov 26, 2024
fe1f1c9 to
5d06ee7
Compare
Collaborator
Author
|
@hipudding, I have updated the code according to your comments, please check it again! Thank you very much! 😊 |
hipudding
approved these changes
Nov 26, 2024
4 tasks
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
Co-authored-by: noemotiovon <noemotiovon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Environment
Inference Tests
Before optimization:
Before this optimization, the inference performance is low at 37.27 token/s on Ascend NPU device. The test logs are showed below.
After optimization:
After this optimization, the inference performance has been significantlly improved on Ascend NPU device, reaching 46.25 token/s. The test logs are showed below.
Operator Tests
Before optimization:
After optimization: