cmake: add link dependencies to cmake find pkg#10433
Merged
slaren merged 6 commits intoggml-org:masterfrom Nov 20, 2024
Merged
Conversation
Member
|
Would it make sense to separate this into a file for ggml (that can be reused by other projects that depend on ggml) and another for llama.cpp? |
Collaborator
Author
|
Yes! Definitely. I can work on adding a separate find module in GGML library. The llama one will then mostly call the GGML find and add the llama target for linking. On the GGML find module it'll add import targets for each backend. |
slaren
approved these changes
Nov 20, 2024
Member
|
Sounds good, should I merge this for now? |
Collaborator
Author
|
Yes, please. 😊 The next PR I'll send will split them up. Thanks. |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
* cmake pkg: find accelerate, openmp, memkind libs * cmake pkg: find BLAS libs * try BLAS_LIBRARIES instead * Add BLAS link opts * Add more link deps. and set GGML_ vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake find package was missing various link libraries required for static builds. In addition, more
GGML_*variables are set to reflect the llama build configuration.