Conversation
danbev
approved these changes
Nov 20, 2024
ggerganov
approved these changes
Nov 20, 2024
JohannesGaessler
approved these changes
Nov 20, 2024
Collaborator
JohannesGaessler
left a comment
There was a problem hiding this comment.
I would be fine with enforcing a specific code style. I don't know about other IDEs/editors but the one I use (Doom Emacs) unfortunately does not highlight code that is in violation of the format specified in.clang_format. I can still format code from the command line using clang-format but one of my weaknesses is that I am prone to forgetting things like this.
It may make sense to amend CONTRIBUTING.md to instruct people to format newly added code.
| SpacesInParentheses: false | ||
| SpacesInSquareBrackets: false | ||
| SpaceBeforeSquareBrackets: false | ||
| Standard: c++17 |
Collaborator
There was a problem hiding this comment.
Shouldn't this be c++11?
Member
Author
There was a problem hiding this comment.
We should be moving to c++17 now. The was some discussion on #10180.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we will be able to use this in large file since it breaks the alignment in many cases, but it should be ok for some files and formatting selections.
Formatted
llama-bench.cppas an example.Note: this
.clang-formatfile is compatible with clang-format 17. It may not work with previous versions.