server : fix incorrect res in validate_model_chat_template#10272
Merged
ggerganov merged 2 commits intoggml-org:masterfrom Nov 13, 2024
Merged
server : fix incorrect res in validate_model_chat_template#10272ggerganov merged 2 commits intoggml-org:masterfrom
ggerganov merged 2 commits intoggml-org:masterfrom
Conversation
5cd0000 to
71c2c7f
Compare
ggerganov
approved these changes
Nov 13, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
…10272) * server : fix validate_model_chat_template * server : fix chat res
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 17, 2024
…10272) * server : fix validate_model_chat_template * server : fix chat res
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
…10272) * server : fix validate_model_chat_template * server : fix chat res
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
llama_chat_apply_templatewill usechatmlas a fallback, so we will never gets res < 0 for models that don't supported chat template, and the warning will never be printed.https://github.com/ggerganov/llama.cpp/blob/54ef9cfc726a799e6f454ac22c4815d037716eda/src/llama.cpp#L21822-L21843