swift : exclude ggml-metal-embed.metal#10211
Merged
ggerganov merged 2 commits intoggml-org:masterfrom Nov 8, 2024
Merged
Conversation
danbev
approved these changes
Nov 8, 2024
| "CMakeLists.txt", | ||
| "Makefile" | ||
| "Makefile", | ||
| "ggml/src/ggml-metal-embed.metal" |
Member
There was a problem hiding this comment.
I think there might be a similar issue with the cmake build. I think something like this might work for cmake if you'd like to add it:
diff --git a/Package.swift b/Package.swift
index d246658b..8a064fd8 100644
--- a/Package.swift
+++ b/Package.swift
@@ -68,7 +68,9 @@ let package = Package(
"tests",
"CMakeLists.txt",
"Makefile",
- "ggml/src/ggml-metal-embed.metal"
+ "ggml/src/ggml-metal-embed.metal",
+ "./build/autogenerated/ggml-metal-embed.metal",
+ "./build/bin/ggml-metal.metal"
],
sources: sources,
resources: resources,
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* llama.swift : exclude ggml-metal-embed.metal * swift : exclude build/
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* llama.swift : exclude ggml-metal-embed.metal * swift : exclude build/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build of llama.swiftui. If we run build like
makebefore, theggml-metal-embed.metalfile will be included in the build in llama.swiftui.xcodebuild -project examples/llama.swiftui/llama.swiftui.xcodeproj -scheme llama.swiftui -sdk iphoneos CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= -destination 'generic/platform=iOS' buildError Logs