server : fix slot selection by lru#10126
Merged
ggerganov merged 2 commits intoggml-org:masterfrom Nov 2, 2024
Merged
Conversation
Contributor
Author
|
@ngxson Could you please review this PR when you have a chance? Thank you! |
ngxson
approved these changes
Nov 2, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* server : fix slot selection by lru, migrate lcs to `size_t` * minor debug log fix
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* server : fix slot selection by lru, migrate lcs to `size_t` * minor debug log fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of the refactoring, the value of
t_last_usedis now not updated when a slot is released, so it is always-1, which causes the first slot to always be selected by LRU. This PR fixes this.That's how it used to be
https://github.com/ggerganov/llama.cpp/blob/7a16ce7db2a74a223f0f3b9cee66d4539c5bce8f/examples/server/server.cpp#L1868-L1883
Also this PR:
inttosize_tin the LCS function