kompute: add backend registry / device interfaces and Q4_K shader#10045
Merged
slaren merged 1 commit intoggml-org:masterfrom Oct 30, 2024
Merged
kompute: add backend registry / device interfaces and Q4_K shader#10045slaren merged 1 commit intoggml-org:masterfrom
slaren merged 1 commit intoggml-org:masterfrom
Conversation
slaren
reviewed
Oct 29, 2024
Member
slaren
left a comment
There was a problem hiding this comment.
I cannot review the other changes, I would suggest keeping them in a separate PR.
Collaborator
Author
Thanks for the review. I've fixed the issues, cleaned up the code a little bit more, and dropped the commit adding the additional shader to deal with it in another PR. |
Get in line with the other backends by supporting the newer backend/device registry interfaces. Signed-off-by: Sergio Lopez <slp@redhat.com>
Collaborator
Author
Thanks, I've just rebased it on top of current master. |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
Get in line with the other backends by supporting the newer backend/device registry interfaces. Signed-off-by: Sergio Lopez <slp@redhat.com>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Get in line with the other backends by supporting the newer backend/device registry interfaces. Signed-off-by: Sergio Lopez <slp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get in line with the other backends by supporting the newer backend/device registry interfaces. While there, also add mul_mat_q4_k shader.