This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Update for the wgpu grand refactor#503
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Aug 13, 2020
Merged
Conversation
There was a problem hiding this comment.
This is an autogenerated code review.New suggestions: 1
Checker summary (by rust_clippy):
The tool has found 0 warnings, 15 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Aug 13, 2020
873: Grand cleanup and refactor of the descriptors in the API r=cwfitzgerald,grovesNL a=kvark **Connections** Cleanup follows gfx-rs/wgpu-rs#501 Fixes #871 Fixes #848 **Description** There is a lot of small and big things crumbled in here. The major one is where descriptors live, and how they are parametrized. Logic is the following: - if something is useful by wgpu-rs's API leave it in `wgpu-types` - if *in addition* it's useful to `wgpu-native`(i.e. has `repr(C)`), we possibly parametrize it (currently, only label is). - otherwise, the type is moved to `wgpu-core` and stripped of generics - remove all the builders Some medium-sized things: - moves the subscriber out (#871) - moves the `RenderCommand` into the `draw` module (which is meant to contain shared things) - makes `TextureViewDescriptor` fields optional, but receives it directly now (#848) - moves stencil stuff out into `StencilStateDescriptor`, so that we can derive `Default` for it - stop accepting raw strings for labels in the `Device` API: neither the clients, or gfx-rs need that shape, and it can't be safe Some smaller things: - using NonZeroU8 for anisotropy - using NonZeroU32 for descriptor count - putting sampler addressing modes into an array - add labels to command buffers and pipeline layouts - improves errors for exceeding binding limits **Testing** Tested on gfx-rs/wgpu-rs#503 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2020
503: Update for the wgpu grand refactor r=kvark a=kvark Depends on gfx-rs/wgpu#873 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2020
503: Update for the wgpu grand refactor r=kvark a=kvark Depends on gfx-rs/wgpu#873 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on gfx-rs/wgpu#873