This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Move backends: BackendBit parameter to Instance::new()#385
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jun 19, 2020
Merged
Move backends: BackendBit parameter to Instance::new()#385bors[bot] merged 1 commit intogfx-rs:masterfrom
backends: BackendBit parameter to Instance::new()#385bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
kvark
approved these changes
Jun 18, 2020
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 18, 2020
730: Move backend selection to `Instance::new()` r=kvark a=Kimundi **Connections** Addresses gfx-rs/wgpu-rs#337 Corresponding wgpu-rs PR: gfx-rs/wgpu-rs#385 **Description** This makes early backend selection possible in `Instance::new`, by only attempting to instantiate requested backends. The actual selection in `pick_adapter()` (necessarily) remains unchanged, and can be used to further restrict the request. **Testing** Unsure what to do here <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See #666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
d2a88c1 to
0ce0700
Compare
4237c60 to
693abce
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337
Blocked on gfx-rs/wgpu#730.