Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Move backends: BackendBit parameter to Instance::new()#385

Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom
Kimundi:backend_bits_in_instance
Jun 19, 2020
Merged

Move backends: BackendBit parameter to Instance::new()#385
bors[bot] merged 1 commit intogfx-rs:masterfrom
Kimundi:backend_bits_in_instance

Conversation

@Kimundi
Copy link
Copy Markdown
Contributor

@Kimundi Kimundi commented Jun 17, 2020

Fixes #337
Blocked on gfx-rs/wgpu#730.

bors bot added a commit to gfx-rs/wgpu that referenced this pull request Jun 18, 2020
730: Move backend selection to `Instance::new()` r=kvark a=Kimundi

**Connections**
Addresses gfx-rs/wgpu-rs#337
Corresponding wgpu-rs PR: gfx-rs/wgpu-rs#385

**Description**
This makes early backend selection possible in `Instance::new`, by only attempting to instantiate requested backends. The actual selection in `pick_adapter()` (necessarily) remains unchanged, and can be used to further restrict the request.

**Testing**
Unsure what to do here
<!--
Non-trivial functional changes would need to be tested through:
  - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples.
  - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity.

Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications.
See #666 for an example.
If you can add a unit/integration test here in `wgpu`, that would be best.
-->


Co-authored-by: Marvin Löbel <loebel.marvin@gmail.com>
@Kimundi Kimundi force-pushed the backend_bits_in_instance branch 3 times, most recently from d2a88c1 to 0ce0700 Compare June 18, 2020 22:08
@Kimundi Kimundi force-pushed the backend_bits_in_instance branch from 4237c60 to 693abce Compare June 18, 2020 23:25
@Kimundi Kimundi marked this pull request as ready for review June 18, 2020 23:58
Copy link
Copy Markdown
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jun 19, 2020

@bors bors bot merged commit 5a7beb6 into gfx-rs:master Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Surface/Instance only for targeted backend

2 participants