This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Merged
Conversation
rukai
reviewed
Jun 18, 2020
rukai
reviewed
Jun 18, 2020
rukai
reviewed
Jun 18, 2020
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 18, 2020
729: Basic support for WGSL r=cwfitzgerald a=kvark Connections: - gfx-rs/wgpu-rs#384 Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
cwfitzgerald
suggested changes
Jun 18, 2020
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Some commentary/nits, but by and large looks good and a good framework for when naga supports more than wgsl.
Member
Author
|
Thank you both for reviewing! This is updated now, PTAL |
cwfitzgerald
approved these changes
Jun 18, 2020
rukai
reviewed
Jun 18, 2020
Member
Author
|
Thank you! Last notes are now addressed. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on gfx-rs/wgpu#729
Makes out shader loading in the examples a bit tidier.