Skip to content

[0.6] fix device feature requests#958

Merged
bors[bot] merged 5 commits intogfx-rs:v0.6from
kvark:0.6-feature
Oct 6, 2020
Merged

[0.6] fix device feature requests#958
bors[bot] merged 5 commits intogfx-rs:v0.6from
kvark:0.6-feature

Conversation

@kvark
Copy link
Copy Markdown
Member

@kvark kvark commented Oct 5, 2020 •
edited
Loading

Connections
Looks like we were requesting a little bit too much?
Also includes #936 and #957

Description
Fix the features requested.

Testing
Confirmed by the virtue of println! :)

@kvark kvark requested a review from cwfitzgerald October 5, 2020 18:49
@kvark kvark mentioned this pull request Oct 5, 2020
Merged
monocodus[bot]
monocodus bot suggested changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

monocodus[bot]
monocodus bot suggested changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

monocodus[bot]
monocodus bot suggested changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

cwfitzgerald
cwfitzgerald approved these changes Oct 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's a helluva oversight. LGTM

bors bot added a commit that referenced this pull request Oct 5, 2020
@bors @kvark
Merge #959
b6e1170 
959: Only request features that are needed r=cwfitzgerald a=kvark

Core part of #958 for master

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark
Copy link
Copy Markdown
Member Author

kvark commented Oct 6, 2020 via email

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 6, 2020

Build succeeded:

@bors bors bot merged commit 3a62c24 into gfx-rs:v0.6 Oct 6, 2020
@kvark kvark deleted the 0.6-feature branch October 6, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

+1 more reviewer

@monocodus monocodus[bot] monocodus[bot] requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvark @cwfitzgerald @kunalmohan