Prevent deserializing or defaulting LoadOp::DontCare, for soundness.#9428
Merged
Conversation
This means it is not possible to create `DontCare` without an unsafe block, as was intended. Putting `serde::skip` on the variant means that the variant cannot be deserialized — it is an error to do so. If in the future we resurrect the wgpu trace/player functionality and want to be able to intentionally deserialize `DontCare`, we can refine this later as a non-breaking change.
slyedoc
pushed a commit
to slyedoc/wgpu
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8780.
Description
Removes
derive(Default)from theLoadOpDontCaretoken, and applies the#[serde::skip]attribute to the variantDontCare. This means it is not possible to createDontCarewithout an unsafe block, as was intended. Attempted deserializing is an error.If in the future we resurrect the wgpu trace/player functionality and want to be able to intentionally deserialize
DontCare, we can refine this later as a non-breaking change.Testing
Added static assertions.
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.