Fix up and enable clip-distances unconditionally for Metal#9270
Merged
ErichDonGubler merged 2 commits intogfx-rs:trunkfrom Mar 20, 2026
Merged
Fix up and enable clip-distances unconditionally for Metal#9270ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
clip-distances unconditionally for Metal#9270ErichDonGubler merged 2 commits intogfx-rs:trunkfrom
Conversation
677d063 to
5d69b63
Compare
ErichDonGubler
commented
Mar 20, 2026
teoxoy
reviewed
Mar 20, 2026
5d69b63 to
a446220
Compare
This only really applies to `[[clip_distances]]` right now, but Teo and I are pretty sure this is the right order for other attributes we might add for array types, too.
a446220 to
ab0cb57
Compare
ab0cb57 to
ce5cb85
Compare
teoxoy
approved these changes
Mar 20, 2026
clip-distances unconditionally for Metalclip-distances unconditionally for Metal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Based on #8762.
Description
I believe this is valid because:
[[clip_distance]].Testing
Existing CTS coverage should be good for this. I've added some snapshot coverage for a fix for incorrectly ordered printing of resolved binding attributes in the case of an array type.
Squash or Rebase?
Rebase.
Checklist
CHANGELOG.mdentry.