Add clip distances validation for maxInterStageShaderVariables#8762
Conversation
2004d9a to
f70488b
Compare
9a8ea87 to
152fedd
Compare
6454d73 to
4a816bf
Compare
wgpu-core/src/validation.rs
Outdated
| ViewIndex, | ||
| BaseInstance, | ||
| BaseVertex, | ||
| ClipDistance { array_size: u32 }, |
There was a problem hiding this comment.
Thoughts on putting array_size: Option<u32> in the naga type rather then duplicating the whole thing?
There was a problem hiding this comment.
The Naga type seems like its usage starts for classifying attributes, which only really makes sense as a flat set of unit variants. Naga might want to grow another representation for attributes and all relevant information, but it doesn't currently have that, and that would be strictly more general than what this is trying to accomplish.
CC @jimblandy and/or @teoxoy for thoughts on this, non-blockingly.
There was a problem hiding this comment.
It doesn't seem most of the variants are used. There is also quite a bit of overlap with InterStageBuiltIn, which despite the name is used for fragment inputs.
There was a problem hiding this comment.
I'm going to merge this, but I'm open to taking on a follow-up issue to fix this, if it bothers folks. I wish I felt like I had the bandwidth to make this better.
ca04a30 to
6a58c70
Compare
5b49daf to
672262f
Compare
07c352f to
e7966f5
Compare
|
The last blocker for merging I haven't figured out yet is GL failures on Linux. CTS appears to believe that limits are wrong, for some reason that I haven't investigated yet. |
|
@ErichDonGubler Can you update this to mention that it closes #6236? |
|
@inner-daemons: It's not clear to me that this exhausts the scope of shipping a fully spec.-compliant implementation of |
78801a1 to
1b39f7f
Compare
1b39f7f to
20ae76f
Compare
63dca1e to
1fab12e
Compare
bfa876f to
aac68c8
Compare
Shortly, we're going to add our own functionality to it.
…_variables` limit check
aac68c8 to
05eb6cf
Compare
Connections
maxInterStageShaderComponentstomaxInterStageShaderVariables(minus coverage ofclip-distances) #8652.Testing
New CTS tests have been enabled that cover this functionality, which were previously failing.
Squash or Rebase?
Rebase.