fix(d12): fix startup crash for shader models 6.8 and 6.9#9083
Merged
ErichDonGubler merged 1 commit intogfx-rs:trunkfrom Feb 21, 2026
Merged
Conversation
7ef8d52 to
72e946c
Compare
6 tasks
Collaborator
|
Oh shit, sorry |
Collaborator
inner-daemons
left a comment
There was a problem hiding this comment.
This would most likely fix the crash, but I don't think we need to add support for new shader models, even if we do, that might not belong in this critical bug-fix PR.
9b6d4fc to
553c299
Compare
inner-daemons
approved these changes
Feb 20, 2026
Collaborator
inner-daemons
left a comment
There was a problem hiding this comment.
One tiny nit here, but it might not be right to fix for readability. Otherwise LGTM (lets get this merged)
553c299 to
0c8a96c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Description
Support was partially added for shader model 6.8, but the
CHANGELOGand logic for actually initializing DX12 with were incomplete. This incompleteness caused crashes (😬 ack!). Finish the work of initializing DX12 devices that have this shader model, and add aCHANGELOGentry.Testing
Builds are fixed in Firefox. I'm not sure how to prevent this going forward (and I think we need to figure this out so this doesn't bite us again; thoughts, @inner-daemons?), but I want to land this ASAP so Firefox isn't blocked from consuming new versions of wgpu.
Squash or Rebase?
Squash please!
Checklist
CHANGELOG.mdentry.