Skip to content

Changed wgpu to default to static dxc when the feature is enabled#8882

Merged
cwfitzgerald merged 7 commits intogfx-rs:trunkfrom
inner-daemons:switch-dxc-default
Feb 11, 2026
Merged

Changed wgpu to default to static dxc when the feature is enabled#8882
cwfitzgerald merged 7 commits intogfx-rs:trunkfrom
inner-daemons:switch-dxc-default

Conversation

@inner-daemons
Copy link
Copy Markdown
Collaborator

@inner-daemons inner-daemons commented Jan 16, 2026

Connections
Closes #8363

Description
Switches the default when a feature is enabled.

Testing
Not needed

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@inner-daemons
Copy link
Copy Markdown
Collaborator Author

@cwfitzgerald I'm gonna redo this implementation later but assign you for now (since you are gonna be assigned anyway in all likelihood)

@inner-daemons inner-daemons reopened this Feb 2, 2026
@inner-daemons inner-daemons marked this pull request as ready for review February 2, 2026 19:28
@inner-daemons
Copy link
Copy Markdown
Collaborator Author

It got closed because I reset it to have no commits. Don't worry about that. Now it uses the approach we talked about.

Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) February 11, 2026 20:21
auto-merge was automatically disabled February 11, 2026 20:49

Head branch was pushed to by a user without write access

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) February 11, 2026 22:01
@cwfitzgerald cwfitzgerald merged commit ed12b74 into gfx-rs:trunk Feb 11, 2026
58 checks passed
@ErichDonGubler
Copy link
Copy Markdown
Member

Heads-up, this caused a regression that I fixed in #9083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider changing default behavior of DX12 to use DXC, with FXC as opt in

3 participants