Merged
Conversation
kvark
approved these changes
Aug 28, 2020
Member
|
actually, can we exclude the wgpu-types version bump? I don't want to release a patch version of wgpu-types just for this, yet |
f648093 to
f054b9e
Compare
kvark
reviewed
Aug 28, 2020
CHANGELOG.md
Outdated
|
|
||
| ## v0.6.1 (tbd) | ||
| - allow copying from Depth32Float textures | ||
| - fix for mixed STORAGE_STORE and STORAGE_LOAD |
Member
There was a problem hiding this comment.
nit: since STORAGE_STORE is not something users see, we should rather say something like "fix usage tracking of read-only buffer storages"
Contributor
Author
There was a problem hiding this comment.
Ah, I see. I just copied the commit message. I'll fix that.
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## v0.6.1 (tbd) | |||
| - allow copying from Depth32Float textures | |||
Member
There was a problem hiding this comment.
let's quote the actual type here i.e. Depth32Float
Contributor
Author
There was a problem hiding this comment.
Sorry, not sure what you mean? Just the backticks?
f054b9e to
a0297bf
Compare
a0297bf to
0218f20
Compare
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald Thanks @JMS55 for bringing this to my attention in gfx-rs#906 Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Remaining backports listed in #905.