Skip to content

[0.6] More backports#906

Merged
kvark merged 3 commits intogfx-rs:v0.6from
malu:remaining-backports-v0.6
Aug 28, 2020
Merged

[0.6] More backports#906
kvark merged 3 commits intogfx-rs:v0.6from
malu:remaining-backports-v0.6

Conversation

@malu
Copy link
Copy Markdown
Contributor

@malu malu commented Aug 28, 2020

Connections
Remaining backports listed in #905.

Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

@kvark
Copy link
Copy Markdown
Member

kvark commented Aug 28, 2020

actually, can we exclude the wgpu-types version bump? I don't want to release a patch version of wgpu-types just for this, yet

@malu malu force-pushed the remaining-backports-v0.6 branch from f648093 to f054b9e Compare August 28, 2020 17:33
Copy link
Copy Markdown
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one last thing!

CHANGELOG.md Outdated

## v0.6.1 (tbd)
- allow copying from Depth32Float textures
- fix for mixed STORAGE_STORE and STORAGE_LOAD
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since STORAGE_STORE is not something users see, we should rather say something like "fix usage tracking of read-only buffer storages"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I just copied the commit message. I'll fix that.

CHANGELOG.md Outdated
@@ -2,6 +2,7 @@

## v0.6.1 (tbd)
- allow copying from Depth32Float textures
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's quote the actual type here i.e. Depth32Float

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure what you mean? Just the backticks?

@malu malu force-pushed the remaining-backports-v0.6 branch from f054b9e to a0297bf Compare August 28, 2020 17:40
@malu malu force-pushed the remaining-backports-v0.6 branch from a0297bf to 0218f20 Compare August 28, 2020 17:42
@kvark kvark merged commit d127963 into gfx-rs:v0.6 Aug 28, 2020
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
907: Add feature request for wgpu-rs r=kvark a=cwfitzgerald

Thanks @JMS55 for bringing this to my attention in gfx-rs#906 

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants