Skip to content

[0.6] Allow copying from Depth32Float formatted textures#904

Merged
kvark merged 2 commits intogfx-rs:v0.6from
malu:copy-from-depth-texture-0.6
Aug 28, 2020
Merged

[0.6] Allow copying from Depth32Float formatted textures#904
kvark merged 2 commits intogfx-rs:v0.6from
malu:copy-from-depth-texture-0.6

Conversation

@malu
Copy link
Copy Markdown
Contributor

@malu malu commented Aug 28, 2020

Connections
Backport of #901

Description
Copying from textures with format Depth32Float was reaching an unreachable and hence was impossible while copying from such textures should be well-defined and safe.

Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

@kvark kvark changed the title Allow copying from Depth32Float formatted textures [0.6] Allow copying from Depth32Float formatted textures Aug 28, 2020
Copy link
Copy Markdown
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
bors r+

bors bot added a commit that referenced this pull request Aug 28, 2020
904: [0.6] Allow copying from Depth32Float formatted textures r=kvark a=malu

**Connections**
Backport of #901 

**Description**
Copying from textures with format `Depth32Float` was reaching an `unreachable` and hence was impossible while copying from such textures should be well-defined and safe.

Co-authored-by: Maximilian Lupke <maxlupke@gmail.com>
Copy link
Copy Markdown
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Aug 28, 2020

Build failed:

@kvark
Copy link
Copy Markdown
Member

kvark commented Aug 28, 2020

argh, that's the generator issue that's still not fixed

@kvark kvark merged commit da91817 into gfx-rs:v0.6 Aug 28, 2020
@kvark kvark mentioned this pull request Aug 28, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants