Merged
Conversation
Member
I don't understand this. Please clarify. If Metal backend doesn't expose this feature, you can't enable it in Oh I see, you are trying to enable it by default, and the result is ignored. Does Metal backend not work? |
Contributor
Author
|
@kvark |
Member
|
ok, lemme fix that in Metal for gfx-0.6 release |
3 tasks
bors bot
added a commit
to gfx-rs/gfx
that referenced
this pull request
Aug 15, 2020
3335: [mtl] add texture cube feature, refactor private caps r=kvark a=kvark Helps gfx-rs/wgpu#877 PR checklist: - [x] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Member
|
don't wait for it though |
Member
|
@StarArawn could you update this? |
Member
|
Could you squash please? |
09ab3ab to
4cb50e8
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
None
Description
Enable
IMAGE_CUBE_ARRAYin vulkan and dx12. Note: Currently this will cause metal to break as theavailable_featuresfrom the physical device will never includeIMAGE_CUBE_ARRAY. Thus I'm opening this as a draft until gfx-hal metal can check and pass the feature on.Testing
I can test this with my repo using wgpu-rs here which uses cube arrays:
https://github.com/StarArawn/harmony/