Fix support for d24unorm format#876
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Aug 13, 2020
Merged
Conversation
Member
Author
|
bors r+ |
Contributor
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Aug 13, 2020
505: Update wgpu to 7e8b51b r=kvark a=kvark Includes gfx-rs/wgpu#876 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
505: Update wgpu to 7e8b51b r=kvark a=kvark Includes gfx-rs#876 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
876: Derive Default for PipelineLayoutDescriptor r=kvark a=dzil123 Co-authored-by: dzil123 <5725958+dzil123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
fixes kvark/vange-rs#121 on some platforms
Description
We used to associate
D24Pluswith internalD24S8. This results in assuming that it has both DEPTH + STENCIL. Creating a binding from it then fails with theAllaspect, since you can't view both. This is unexpected, since the user createsD24Pluswith just a single aspect.Testing
None needed