Gate DX12 mesh shader command signature initialization on device support.#8297
Merged
cwfitzgerald merged 4 commits intogfx-rs:trunkfrom Oct 4, 2025
Conversation
inner-daemons
approved these changes
Oct 3, 2025
Collaborator
inner-daemons
left a comment
There was a problem hiding this comment.
I've looked it over and it looks good to me. Just FYI you will probably have to create a PR to backport this to 27.0.
cwfitzgerald
requested changes
Oct 3, 2025
Contributor
Author
|
PTAL - addressed comments and added changelog entry. |
cwfitzgerald
approved these changes
Oct 4, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Amazing, will backport and get this out
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 4, 2025
vorporeal
added a commit
to warpdotdev/wgpu
that referenced
this pull request
Oct 8, 2025
vorporeal
added a commit
to warpdotdev/wgpu
that referenced
this pull request
Oct 8, 2025
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8296.
Description
Addresses crashes when initializing a DX12 device that lacks support for mesh shaders.
This conditions creation of the command signatures for indirect mesh shader dispatch on the device supporting mesh shaders. The code here generally follows the patterns used in other backends (e.g.: Vulkan).
Testing
cargo run --bin wgpu-examples hello_triangle(withWGPU_ADAPTER_NAMEset to my Intel iGPU) that thehello_triangleexample now runs properly.mesh_shaderexample that mesh shaders still work with supported devices - setWGPU_ADAPTER_NAMEto my dedicated GPU (which worked), and set it to my integrated GPU, which failed withAdapter does not support required features for this example: Features { features_wgpu: FeaturesWGPU(EXPERIMENTAL_MESH_SHADER), features_webgpu: FeaturesWebGPU(0x0) }.Squash or Rebase?
Squash - will want to add a commit with changelog updates once we agree on impl.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.