Derive Hash on BindGroupLayoutEntry#799
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jul 16, 2020
Merged
Conversation
Contributor
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 0 warnings, 66 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
Member
|
@kunalmohan 66 errors in in 2 lines, that's pretty impressive! |
Contributor
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
799: Update naga to gfx-16 r=kvark a=kvark Makes WGSL constants much more ergonomic to write, and fixes the issues we had with the water example. Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Required in Servo.
Testing
Explain how this change is tested.
Not tested.