Merged
Conversation
13 tasks
teoxoy
reviewed
May 21, 2025
Member
teoxoy
left a comment
There was a problem hiding this comment.
Looks good overall, thanks for reviving this!
teoxoy
approved these changes
May 26, 2025
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* Rudimentary impl of quad ops, impl quad ops for spirv * Impl quad swap for hlsl, msl and wgsl, finish spv front * Cargo clippy & cargo fmt, impl valid for quad ops * Enable quad feature * Add missing feature to glsl * Simplifying code by making `SubgroupQuadSwap` an instance of `SubgroupGather` * Add `GroupNonUniformQuad` spv capability to Vulkan * Adding GPU tests for quad operations * Validate that broadcast operations use const invocation ids * Added changelog entry --------- Co-authored-by: valaphee <32491319+valaphee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Partially solves #5555
Resolves #5670
Description
Resurrecting #5684, which implements WGSL's (now accepted) quad operations:
trunkQuadSwapoperations an instance ofSubgroupGather, simplifying the codeTesting
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.