Skip to content

Add textureBarrier#7173

Merged
teoxoy merged 7 commits intogfx-rs:trunkfrom
Devon7925:trunk
Feb 27, 2025
Merged

Add textureBarrier#7173
teoxoy merged 7 commits intogfx-rs:trunkfrom
Devon7925:trunk

Conversation

@Devon7925
Copy link
Copy Markdown
Contributor

@Devon7925 Devon7925 commented Feb 17, 2025

Connections
closes #4704
closes #6204

Description
Adds support for textureBarrier.

Testing
Added textureBarrier commands to control-flow and seperate-entry-points tests where other barriers were used.

@Devon7925 Devon7925 marked this pull request as ready for review February 17, 2025 23:40
@Devon7925
Copy link
Copy Markdown
Contributor Author

MSL test fails because mem_texture is newer:

macOS: Metal 1.2 and later.
iOS: Metal 2 and later.

Does naga only support metal <1.2 or is there some check I can do for the metal version?

@cwfitzgerald
Copy link
Copy Markdown
Member

In the param.ron file you can set msl.lang_version to the minimum for that test.

Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@teoxoy
Copy link
Copy Markdown
Member

teoxoy commented Feb 27, 2025

@Devon7925 looks like there are some conflicts, could you rebase the PR?

@teoxoy teoxoy merged commit d6ca412 into gfx-rs:trunk Feb 27, 2025
34 checks passed
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WGSL: Support the readonly_and_readwrite_storage_textures language extension Align with the spec on read-only and read-write storage textures

3 participants