Merged
Conversation
cwfitzgerald
commented
Feb 7, 2025
nical
reviewed
Feb 10, 2025
Contributor
nical
left a comment
There was a problem hiding this comment.
Nice! It looks worthy of a changelog entry.
6 tasks
Member
Author
|
Changelog added |
Wumpf
requested changes
Feb 11, 2025
wgpu-core/platform-features/windows-linux-android-emscripten/src/lib.rs
Outdated
Show resolved
Hide resolved
wgpu-core/platform-features/windows-linux-android-emscripten/Cargo.toml
Outdated
Show resolved
Hide resolved
…onditional-compilation # Conflicts: # CHANGELOG.md
Wumpf
approved these changes
Feb 22, 2025
Member
Wumpf
left a comment
There was a problem hiding this comment.
awesome. very happy about this now. shipping time!
Comment on lines
+147
to
+157
| # The target limitation here isn't needed, but prevents more than one of these | ||
| # platform crates from being included in the build at a time, preventing users | ||
| # from getting confused by seeing them in the list of crates. | ||
| [target.'cfg(target_vendor = "apple")'.dependencies] | ||
| wgpu-core-deps-apple = { workspace = true, optional = true } | ||
| [target.'cfg(target_os = "emscripten")'.dependencies] | ||
| wgpu-core-deps-emscripten = { workspace = true, optional = true } | ||
| [target.'cfg(all(target_arch = "wasm32", not(target_os = "emscripten")))'.dependencies] | ||
| wgpu-core-deps-wasm = { workspace = true, optional = true } | ||
| [target.'cfg(any(windows, target_os = "linux", target_os = "android"))'.dependencies] | ||
| wgpu-core-deps-windows-linux-android = { workspace = true, optional = true } |
Member
There was a problem hiding this comment.
clever! it's technically also a lil bit faster because then there's a smaller number of crates that cargo has to dispatch and makes the --timings report better
Member
ah shoot. I forgot again about that piece. I'll do a follow-up! |
6 tasks
6 tasks
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further attempt target specific stuff
Closes #7064
Closes #6949
Closes #3514