Skip to content

Ban Dynamic Offsets and Binding Arrays in the Same Bind Group#6811

Merged
cwfitzgerald merged 2 commits intogfx-rs:trunkfrom
cwfitzgerald:cw/ban-texture-arrays-and-dynamic-offsets
Jan 20, 2025
Merged

Ban Dynamic Offsets and Binding Arrays in the Same Bind Group#6811
cwfitzgerald merged 2 commits intogfx-rs:trunkfrom
cwfitzgerald:cw/ban-texture-arrays-and-dynamic-offsets

Conversation

@cwfitzgerald
Copy link
Copy Markdown
Member

@cwfitzgerald cwfitzgerald commented Dec 23, 2024

Closes #6736

We also need to ban uniform buffers and binding arrays.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner December 23, 2024 05:57
@cwfitzgerald cwfitzgerald force-pushed the cw/ban-texture-arrays-and-dynamic-offsets branch 2 times, most recently from 8aaa218 to 4ef5eb1 Compare December 23, 2024 07:54
@cwfitzgerald

This comment was marked as resolved.

@cwfitzgerald cwfitzgerald marked this pull request as draft December 24, 2024 00:32
@cwfitzgerald cwfitzgerald force-pushed the cw/ban-texture-arrays-and-dynamic-offsets branch from 4ef5eb1 to 189f27c Compare January 19, 2025 21:07
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 19, 2025 21:07
Copy link
Copy Markdown
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy self-assigned this Jan 20, 2025
@cwfitzgerald cwfitzgerald merged commit 4ed5021 into gfx-rs:trunk Jan 20, 2025
@cwfitzgerald cwfitzgerald deleted the cw/ban-texture-arrays-and-dynamic-offsets branch January 20, 2025 18:46
davnotdev pushed a commit to davnotdev/wgpu that referenced this pull request Mar 4, 2025
…#6811)

* Ban Dynamic Offsets and Binding Arrays in the Same Bind Group

* Add Tests and Uniform Buffer Restriction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow Binding Arrays and Dynamic Offsets in Same Bind Group

2 participants