Enforce copy buffer-texture alignment#679
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Jun 1, 2020
Merged
Conversation
cwfitzgerald
requested changes
Jun 1, 2020
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
One nit, and one question, otherwise LGTM
Member
Author
|
Thank you for reviewing! |
Contributor
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
679: WGSL shader conversion for the examples r=grovesNL a=kvark Blocked on: - ~~gfx-rs/naga#335 - ~~gfx-rs/naga#336 - ~~gfx-rs#1095 - ~~gfx-rs/naga#360 - gfx-rs/gfx#3622 - ~~GL backend doing the program link check earlier~~ Converted: - [x] boids - [x] cube - [x] mipmap - [x] msaa-line - [x] shadow - [x] skybox - [ ] texture-array - [ ] water Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
This is a follow-up to #666
Description
We are now enforcing the
bytes_per_rowon copy-texture copies toCOPY_BYTES_PER_ROW_ALIGNMENT.We allow it being non-aligned for
write_texture, which now has the code to properly align the staging space it uses, and to copy the rows one by one with proper alignment.We are also moving
BufferSizeto wgpu-types, because it's required for wgpu-rs to build.Testing
Testing this needs gfx-rs/wgpu-rs#328, which is blocked by gfx-rs/wgpu-rs#323