@JMS55 So, why wasn't tests/in/atomicOps-int64-min-max.wgsl broken by the absence of the fix in naga/src/front/wgsl/lower/mod.rs?

I couldn't figure that out. My best guess is that maybe the fact that the second argument is not an expression matters. Maybe a constant vs expression in the second argument changes how things get parsed or something.

The clippy warnings are specific to this branch, they don't happen on trunk. I can see them with:

cargo +1.76 clippy -p naga --features=hlsl-out

I would like to have a snapshot test that is affected by the change to naga/src/front/wgsl/lower/mod.rs. I'm uncomfortable that we have no tests that can detect that fix.

I didn't change that code though, so idk why clippy is complaining only on this branch... I mean I can make the fixes as part of this PR if you want, up to you.

I didn't change that code though, so idk why clippy is complaining only on this branch... I mean I can make the fixes as part of this PR if you want, up to you.

Yes, please change this PR so it does not break CI on trunk when it is merged.

I would like to have a snapshot test that is affected by the change to naga/src/front/wgsl/lower/mod.rs. I'm uncomfortable that we have no tests that can detect that fix.

I volunteered to work on this in chat.

@JMS55 So, why wasn't tests/in/atomicOps-int64-min-max.wgsl broken by the absence of the fix in naga/src/front/wgsl/lower/mod.rs?

It seems like the reason is, the final operands to the atomicMax and atomicMin calls in the snapshot are all simple expressions that don't need to be emitted. I've pushed a commit that uses a variety of final operands, and that causes a panic without the fix.