Skip to content

Naga emits wrong HLSL for atomicMax() on u64 buffer #5893

@JMS55

Description

@JMS55

Description
Naga should be emitting buffer.InterlockedMax64, not buffer.InterlockedMax.

This only applies to RWByteAddressBuffer according to the spec.

This issue also applies to the other atomic functions.

Repro steps

@group(0) @binding(0) var<storage, read_write> buf: atomic<u64>;

atomicMax(&buf, 3147483647lu);

Platform
Naga rev 82210e1c

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: naga back-endOutputs of naga shader conversionlang: HLSLD3D Shading LanguagenagaShader Translatortype: bugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions