-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Naga emits wrong HLSL for atomicMax() on u64 buffer #5893
Copy link
Copy link
Closed
Labels
area: naga back-endOutputs of naga shader conversionOutputs of naga shader conversionlang: HLSLD3D Shading LanguageD3D Shading LanguagenagaShader TranslatorShader Translatortype: bugSomething isn't workingSomething isn't working
Description
Description
Naga should be emitting buffer.InterlockedMax64, not buffer.InterlockedMax.
This only applies to RWByteAddressBuffer according to the spec.
This issue also applies to the other atomic functions.
Repro steps
@group(0) @binding(0) var<storage, read_write> buf: atomic<u64>;
atomicMax(&buf, 3147483647lu);Platform
Naga rev 82210e1c
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: naga back-endOutputs of naga shader conversionOutputs of naga shader conversionlang: HLSLD3D Shading LanguageD3D Shading LanguagenagaShader TranslatorShader Translatortype: bugSomething isn't workingSomething isn't working
Type
Projects
Status
Done