Merged
Conversation
grovesNL
approved these changes
Mar 31, 2020
| type Filter = Mutex<IdentityManager>; | ||
| fn spawn(&self) -> Self::Filter { | ||
| Mutex::new(IdentityManager::default()) | ||
| fn spawn(&self, min_index: Index) -> Self::Filter { |
Collaborator
There was a problem hiding this comment.
Could you explain why min_index is useful for Backend::Empty only? It seems like we're trying to avoid colliding with SurfaceId::ERROR but I'm wondering why it's not necessary to do this for other IDs and backends
Member
Author
There was a problem hiding this comment.
I should put a comment in there. The reason is because Empty == 0. So only ID=0 with Epoch=0 on Empty backend ends up with u64 value == 0. Other backends are guaranteed to be non-zero in raw values.
Member
Author
|
bors r=grovesNL |
Contributor
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
545: Remove bake.frag from shadow example r=kvark a=yutannihilation Now that `fragment_stage` is a `Option`, I guess this is the case when we don't need fragment shader. Co-authored-by: Hiroaki Yutani <yutani.ini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #543
Follows the proposal of webgpu-native/webgpu-headers#39