Add Clone and PartialEq implementations for SamplerDescriptor#527
Merged
bors[bot] merged 1 commit intogfx-rs:masterfrom Mar 22, 2020
Merged
Add Clone and PartialEq implementations for SamplerDescriptor#527bors[bot] merged 1 commit intogfx-rs:masterfrom
Clone and PartialEq implementations for SamplerDescriptor#527bors[bot] merged 1 commit intogfx-rs:masterfrom
Conversation
Helps when attempting to support multiple samplers in an immediate mode context (e.g. easily compare sampler descriptors and check if I need to add a command to switch bind groups).
bors bot
added a commit
that referenced
this pull request
Mar 20, 2020
527: Add `Clone` and `PartialEq` implementations for `SamplerDescriptor` r=kvark a=mitchmindtree Helps when attempting to support multiple samplers in an immediate mode context (e.g. easily compare sampler descriptors and check if I need to add a command to switch bind groups). Co-authored-by: mitchmindtree <mitchell.nordine@gmail.com>
Member
|
bors retry |
Contributor
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
527: Expose debug marker/groups for ComputePass and Encoder r=kvark a=Wumpf Added uses of them to the examples to make sure everything compiles & works. Marker on compute examples are arguably a bit awkward since they are so trivial. On the shadow example however it is a delight when inspected in RenderDoc! (and it will do wonders to my project which can run into situations with literally thousands of compute dispatches per frame 😅 ) RenderDoc, boids example:  RenderDoc, shadow example:  Co-authored-by: Andreas Reich <r_andreas2@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps when attempting to support multiple samplers in an immediate mode
context (e.g. easily compare sampler descriptors and check if I need to
add a command to switch bind groups).