Skip to content

Docs surface creation no longer unsafe#5265

Merged
Wumpf merged 2 commits intogfx-rs:trunkfrom
hackaugusto:docs-surface-creation-no-longer-unsafe
Feb 19, 2024
Merged

Docs surface creation no longer unsafe#5265
Wumpf merged 2 commits intogfx-rs:trunkfrom
hackaugusto:docs-surface-creation-no-longer-unsafe

Conversation

@hackaugusto
Copy link
Copy Markdown
Contributor

Connections
None

Description
Small changes to the docs

Testing
None

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@hackaugusto hackaugusto requested a review from a team as a code owner February 18, 2024 16:09
@hackaugusto hackaugusto force-pushed the docs-surface-creation-no-longer-unsafe branch from 77a6c92 to b787cda Compare February 18, 2024 18:01
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat, thank you!

@Wumpf Wumpf enabled auto-merge (squash) February 18, 2024 19:59
@hackaugusto
Copy link
Copy Markdown
Contributor Author

it seems there is a flaky text in the windows build. I can't restart the CI though.

@Wumpf Wumpf merged commit a302c8d into gfx-rs:trunk Feb 19, 2024
@hackaugusto hackaugusto deleted the docs-surface-creation-no-longer-unsafe branch February 19, 2024 11:31
@cwfitzgerald cwfitzgerald added the PR: needs back-porting PR with a fix that needs to land on crates label Feb 29, 2024
cwfitzgerald pushed a commit to cwfitzgerald/wgpu that referenced this pull request Feb 29, 2024
* doc: as of gfx-rs#4597 surface creation is no longer unsafe

* doc: extend documentation of the include_wgsl macro
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants