Pin web-sys to 0.3.67 since we are using unstable APIs#5224
Pin web-sys to 0.3.67 since we are using unstable APIs#5224hecrj wants to merge 1 commit intogfx-rs:trunkfrom
web-sys to 0.3.67 since we are using unstable APIs#5224Conversation
|
This would be worthwhile if |
|
It certainly will break builds for some users, but they will break upfront. The current approach allows for Wasm builds to break after the fact, in code that has already been released. In fact, |
|
This imposes a very large cost on all users of only stable features ("don't upgrade your other dependencies") in order to benefit users of unstable features. |
|
Hmm, would it be possible to have two |
|
This doesn't solve the immediate problem, but: We currently plan on upgrading |
| wasm-bindgen-futures = "0.4.40" | ||
| wasm-bindgen-test = "0.3" | ||
| web-sys = "0.3.67" | ||
| web-sys = "=0.3.67" |
There was a problem hiding this comment.
It would be good to have a comment here explaining why we are pinning to a specific version.
It may be possible with a bit of conditional compilation. I'll look into it. |
Connections
web-syspatch version0.3.68wasm-bindgen/wasm-bindgen#3834Description
wgpurelies on unstable APIs of theweb-syscrate and the latest0.3.68version breaks types related to WebGPU.Since semantic versioning isn't enforced for unstable APIs in
web-sys, we should rely instead on a specific crate version to avoid broken builds in the future.Testing
N/A
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.