Refactor tests to be feature flag bit-width agnostic#5155
Merged
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom Jan 28, 2024
Merged
Refactor tests to be feature flag bit-width agnostic#5155cwfitzgerald merged 1 commit intogfx-rs:trunkfrom
cwfitzgerald merged 1 commit intogfx-rs:trunkfrom
Conversation
cwfitzgerald
approved these changes
Jan 28, 2024
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Nice, we've needed this for a while!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Part of an incoming series of PRs needed by #5123
Others in this series: #5154
Ultimately for bevy meshlets pipeline bevyengine/bevy#10164
Description
Refactor tests to be feature flag bit-width agnostic. This is to make it possible to easily change Features from u64 to u128 in the future. This will be needed because we are out of feature flag space to add new ones.
Testing
This only affects existing tests, and the tests still pass.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.